Skip to content

fix InputField helperText padding#12527

Merged
pankaj-pant merged 2 commits into
developfrom
helperText-padding
May 14, 2026
Merged

fix InputField helperText padding#12527
pankaj-pant merged 2 commits into
developfrom
helperText-padding

Conversation

@pankaj-pant
Copy link
Copy Markdown
Contributor

@pankaj-pant pankaj-pant commented May 5, 2026 •
edited
Loading

Description

Fix helperText padding - slack thread - https://opencrvsworkspace.slack.com/archives/C02P91N0E1W/p1777971392374909

Design - figma.com/design/W6Bty2ujZg29tv5CPWzCcd/OpenCRVS-Design-System....?t=7FpXda6QQ3xrXomM-0

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026 •
edited
Loading

ℹ️ Coverage metrics explained:
• Statements — Executed code statements (basic logic lines)
• Branches — Tested decision paths (if/else, switch, ternaries)
• Functions — Functions invoked during tests
• Lines — Source lines executed

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026 •
edited
Loading

📊 commons test coverage

Statements: 75.9%
Branches:   40.49%
Functions:  58.37%
Lines:      75.47%
Updated at: Thu, 14 May 2026 08:10:18 GMT

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026 •
edited
Loading

📊 events test coverage

Statements: 86.95%
Branches:   85.17%
Functions:  92.16%
Lines:      86.95%
Updated at: Thu, 14 May 2026 08:17:51 GMT

@pankaj-pant pankaj-pant requested a review from naftis May 14, 2026 08:09
@naftis
Copy link
Copy Markdown
Member

naftis commented May 14, 2026

@pankaj-pant

opencrvs-core/packages/components/src/InputField/InputField.tsx

Line 39 in dc4fba1

padding-bottom: 0;

can't remember why but I overrode the padding rule here, would it make sense to rather put this to 8px?

@pankaj-pant pankaj-pant merged commit f78b798 into develop May 14, 2026
62 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naftis naftis naftis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pankaj-pant @naftis